lkml.org 
[lkml]   [2007]   [Mar]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]
    Date
    Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

    > > +static inline int try_to_cancel_delayed_work(struct delayed_work *work)
    > > +{
    > > + int ret;
    >
    > This expands to a fair bit of code and IMHO isn't an inline candidate.

    Then why is cancel_delayed_work() inline? It's very similar in terms of
    expansion.

    And it's not a fair bit of code. try_to_cancel_delayed_work() is out of line,
    and work_release() is just clear_bit() in disguise.

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-16 15:25    [W:0.018 / U:60.748 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site