Messages in this thread | | | Date | Thu, 15 Mar 2007 05:36:07 +0000 | From | Al Viro <> | Subject | Re: [PATCH 10/13] BLK_DEV_IDE_CELLEB dependency fix |
| |
On Thu, Mar 15, 2007 at 02:25:40PM +0900, Akira Iguchi wrote: > Al wrote: > > > >It's bool and it depends on IDE => should depend on IDE=y > > > >Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > > Move to "if BLK_DEV_IDEDMA_PCI" block because it depends on > BLK_DEV_IDEDMA_PCI.
> +config BLK_DEV_IDE_CELLEB > + bool "Toshiba's Cell Reference Set IDE support" > + depends on PPC_CELLEB > + help > + This driver provides support for the built-in IDE controller on > + Toshiba Cell Reference Board. > + If unsure, say Y. > +
Eh... You still need dependency on IDE=y; otherwise you'll get configs with IDE=m, BLK_DEV_IDE_CELLEB=y and those won't link. BLK_DEV_IDEDMA_PCI is selectable just fine with IDE=m.
It's the same problem as with ps3 fb. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |