Messages in this thread | | | Date | Thu, 15 Mar 2007 23:59:29 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed |
| |
On Thu, Mar 15, 2007 at 05:44:01PM +0000, Hugh Dickins wrote: > who removed the !offset condition, he should be consulted on its > reintroduction.
the !offset check looks a pretty broken heuristic indeed, it would break random I/O. The real fix is to add a ra.prev_offset along with ra.prev_page, and if who implements it wants to be stylish he can as well use a ra.last_contiguous_read structure that has a page and offset fields (and then of course remove ra.prev_page). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |