lkml.org 
[lkml]   [2007]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm/filemap.c: unconditionally call mark_page_accessed
    On Thu, Mar 15, 2007 at 07:46:56AM -0500, Dave Kleikamp wrote:
    > On Thu, 2007-03-15 at 01:22 -0400, Ashif Harji wrote:
    >
    > > I would tend to agree with David that: "Any application doing many
    > > tiny-sized reads isn't exactly asking for great performance." As well,
    > > applications concerned with performance and caching problems can read in a
    > > file in PAGE_SIZE chunks. I still think the simple fix of removing the
    > > condition is the best approach, but I'm certainly open to alternatives.
    >
    > A possible alternative might be to store the offset within the page in
    > the readahead state, and call mark_page_accessed() when the read offset
    > is less than or equal to the previous offset.

    That could be a good idea.

    We definitely want to look at ways to solve with within the existing
    approach before any large scale change in behaviour.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-15 13:53    [W:0.018 / U:30.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site