Messages in this thread | | | Date | Wed, 14 Mar 2007 19:42:08 -0400 | From | Benjamin LaHaise <> | Subject | Re: [patch 13/13] signalfd/timerfd/asyncfd v5 - KAIO asyncfd support (example/maybe-broken) ... |
| |
On Wed, Mar 14, 2007 at 04:24:54PM -0700, Davide Libenzi wrote: > Can you point me to a kernel path that ends up calling aio_complete() in a > do-not-sleep mode?
If you remove that invariant, then it is very difficult for device drivers and other code to make use of aio_complete().
> The offender I see is drivers/usb/gadget/inode.c that calls it with a > spinlock held.
Which was from irq context last time I checked.
> The aio_run_iocb function seem to release/reacquire the lock before > calling aio_complete().
That implies nothing -- aio_complete() has to acquire ctx_lock and cannot be called holding the lock. Sure, it could probably be split into __aio_complete() and have aio_complete() wrap it acquiring the lock.
-ben -- "Time is of no importance, Mr. President, only life is important." Don't Email: <zyntrop@kvack.org>. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |