Messages in this thread | | | Date | Wed, 14 Mar 2007 18:23:10 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH 13/13] fix ps3fb glue allowing a modular build |
| |
On Wed, 14 Mar 2007, Al Viro wrote: > On Wed, Mar 14, 2007 at 05:17:45PM +0100, Geert Uytterhoeven wrote: > > On Wed, 14 Mar 2007, Al Viro wrote: > > > On Wed, Mar 14, 2007 at 10:50:16AM +0100, Geert Uytterhoeven wrote: > > > > On Wed, 14 Mar 2007, Al Viro wrote: > > > > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > > > > > > > > NAK > > > > > > Lovely... Consider that one withdrawn, please. FWIW, if we leave it bool > > > (and flip_ctl mess alone would make a good reason for that) we probably want > > > to have it depend on FB=y > > > > What's the advantage of making FB_PS3 depend on FB=y vs. plain FB? > > In both cases it can be enabled if FB=y only, right? Or am I missing something? > > Nope. How can kconfig distinguish that from a boolean option in modular > driver? bool *can* depend on tristate and be selected when tristate is > set to m.
Sorry, you're right. I tried it before sending the previous mail, but apparently I made a mistake. I tried again, and now it indeed allows me to select FB_PS3.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE) Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1 Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |