Messages in this thread | | | Date | Wed, 14 Mar 2007 17:08:34 +0000 | From | "Catalin Marinas" <> | Subject | Re: Possible "struct pid" leak from tty_io.c |
| |
On 14/03/07, Eric W. Biederman <ebiederm@xmission.com> wrote: > How does this look?
It seems to fix the leak. I looked at the logs and proc_set_tty calls put_pid twice for pid 245 (the unresolved leak) and get_pid for pid 296, which is later passed to put_pid via do_tty_hangup.
I still get the "error attempted to write to tty [0x00000000] = NULL" when debugging is enabled in tty_io.c but it seems harmless.
> I don't have the setup to test this easily, but this bit makes seems to > make sense.
And I don't have a fully tested kmemleak patch to post either :-).
Thanks.
-- Catalin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |