lkml.org 
[lkml]   [2007]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 18/18] Straight file moves


    On Wed, 14 Mar 2007, Steven Rostedt wrote:
    >
    > Here's a list of files that were moved from either i386 or x86_64 over
    > to the arch/x86 directory.

    Well, this means that your patch series doesn't actually *compile* as a
    series.

    In other words, it's a pointless series, since the individual patches just
    generate a non-working kernel, until they have all been applied.

    So I really meant that each patch should be generated with "git diff -M",
    and you'd have a series of patches that are all working and move one part
    of the tree at a time (with Makefile changes etc integrated).

    Also, in case you didn't notice, it's also perfectly fine to have
    "impure" moves, ie a move that not only renames something, but also
    changes something (commonly the comments at the top of the file). Maybe
    you simply didn't have anything like that, but I thought I'd mention it
    just in case you tried to avoid it on purpose.

    The reason I really want the whole series to be compileable is that
    especially with a lot of people using "git bisect", if you have something
    that doesn't compile in the middle, not only does it show that the series
    wasn't a series, it also means that you cannot automate the bisect and you
    need manual intervention.

    Linus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-14 16:49    [W:0.026 / U:59.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site