Messages in this thread Patch in this message | | | Date | Tue, 13 Mar 2007 18:05:46 +0900 | From | Paul Mundt <> | Subject | Re: [QUICKLIST 1/4] Generic quicklist implementation |
| |
On Tue, Mar 13, 2007 at 12:13:30AM -0700, Christoph Lameter wrote: > --- linux-2.6.21-rc3-mm2.orig/mm/Kconfig 2007-03-12 22:49:21.000000000 -0700 > +++ linux-2.6.21-rc3-mm2/mm/Kconfig 2007-03-13 00:09:50.000000000 -0700 > @@ -220,3 +220,8 @@ config DEBUG_READAHEAD > > Say N for production servers. > > +config QUICKLIST > + bool > + default y if NR_QUICK != 0 > + > +
This doesn't work, and so CONFIG_QUICKLIST is always set. The NR_QUICK thing seems a bit backwards anyways, perhaps it would make more sense to have architectures set CONFIG_GENERIC_QUICKLIST in the same way that the other GENERIC_xxx bits are defined, and then set NR_QUICK based off of that. It's obviously going to be 2 or 1 for most people, and x86 seems to be the only one that needs 2.
How about this?
--
diff --git a/mm/Kconfig b/mm/Kconfig index 7942b33..2f20860 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -163,3 +163,8 @@ config ZONE_DMA_FLAG default "0" if !ZONE_DMA default "1" +config NR_QUICK + int + depends on GENERIC_QUICKLIST + default "2" if X86 + default "1" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |