lkml.org 
[lkml]   [2007]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: irda rmmod lockdep trace.
    On Mon, Mar 12, 2007 at 04:49:21PM -0700, David Miller wrote:
    > I would strongly caution against adding any run-time overhead just to
    > cure a false lockdep warning. Even adding a new function argument
    > is too much IMHO.
    >
    > Make the cost show up for lockdep only, perhaps by putting each
    > hashbin lock into a seperate locking class?
    Does that look better to you:

    diff --git a/include/net/irda/irqueue.h b/include/net/irda/irqueue.h
    index 335b0ac..67cb434 100644
    --- a/include/net/irda/irqueue.h
    +++ b/include/net/irda/irqueue.h
    @@ -71,6 +71,7 @@ typedef struct hashbin_t {
    int hb_size;
    spinlock_t hb_spinlock; /* HB_LOCK - Can be used by the user */

    + struct lock_class_key hb_lock_key;
    irda_queue_t* hb_queue[HASHBIN_SIZE] IRDA_ALIGN;

    irda_queue_t* hb_current;
    diff --git a/net/irda/irqueue.c b/net/irda/irqueue.c
    index 9266233..c72ecee 100644
    --- a/net/irda/irqueue.c
    +++ b/net/irda/irqueue.c
    @@ -370,6 +370,8 @@ hashbin_t *hashbin_new(int type)
    /* Make sure all spinlock's are unlocked */
    if ( hashbin->hb_type & HB_LOCK ) {
    spin_lock_init(&hashbin->hb_spinlock);
    + lockdep_set_class(&hashbin->hb_spinlock,
    + &hashbin->hb_lock_key);
    }

    return hashbin;



    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-14 01:53    [W:0.021 / U:3.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site