lkml.org 
[lkml]   [2007]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 2/4] [TULIP] Quiet down tulip_stop_rxtx
    Only print out debugging info for tulip_stop_rxtx if debug is on.
    Many cards (including at least two of my own) fail to stop properly
    during initialization according to this test with no apparent ill
    effects. Worse, it tends to spam logs when the driver doesn't work.

    Signed-off-by: Val Henson <val_henson@linux.intel.com>
    Signed-off-by: Grant Grundler <grundler@parisc-linux.org>
    Cc: Jeff Garzik <jeff@garzik.org>

    ---
    drivers/net/tulip/tulip.h | 2 +-
    1 files changed, 1 insertion(+), 1 deletion(-)

    --- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip.h
    +++ tulip-2.6-mm-linux/drivers/net/tulip/tulip.h
    @@ -481,7 +481,7 @@ static inline void tulip_stop_rxtx(struc
    while (--i && (ioread32(ioaddr + CSR5) & (CSR5_TS|CSR5_RS)))
    udelay(10);

    - if (!i)
    + if (!i && (tulip_debug > 1))
    printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed"
    " (CSR5 0x%x CSR6 0x%x)\n",
    pci_name(tp->pdev),
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-12 11:01    [W:0.023 / U:129.836 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site