Messages in this thread | | | Date | Mon, 12 Mar 2007 23:39:06 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) |
| |
Hi!
> > > Looks good to me! The other kthread_should_stop() calls in > > > rcutorture.c should also become > > > kthread_should_top_check_freeze().
> > Why is it useful? > > Because we want to avoid repeating > > while (!kthread_should_stop()) { > try_to_freeze(); > ... > } > > in many places?
Do not do it, then. Confusion it causes is not worth saving one line of code.
You do less typing, but the resulting code is _less_ readable, not more.
NAK.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |