Messages in this thread | | | Date | Mon, 12 Mar 2007 15:53:59 +0100 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH v2] Bitbanging i2c bus driver using the GPIO API |
| |
On Mon, 12 Mar 2007 15:34:57 +0100 Haavard Skinnemoen <hskinnemoen@atmel.com> wrote:
> > > + bit_data->udelay = 5, /* 100 kHz */ > > > + bit_data->timeout = HZ / 10, /* 100 ms */ > > > > Can we add these udelay/timeout to struct i2c_gpio_platform_data? And > > let customer to choose these according their specific requirement. We > > use Kconfig to do this, but Jean and David don't like the idea, -:( > > Yeah, they need to be a bit more configurable than they currently are. > And I think it makes sense to pass them from the board setup code, since > this is where things depending on board-specific details (signal quality > issues, pullup resistor values, etc.) are supposed to go.
By the way, timeout seems to be hardcoded to 100 jiffies in the i2c-algo-bit driver, so there's probably not much point passing it from the board code when it's going to be overridden anyway. I'll add just a udelay parameter to the platform struct for now.
Haavard - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |