lkml.org 
[lkml]   [2007]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 4/5] Blackfin: patch add blackfin support in smc91x ethernet controller driver
    On Thu, 01 Mar 2007 12:15:29 +0800 "Wu, Bryan" <bryan.wu@analog.com> wrote:

    > +/* check if the mac in reg is valid */
    > +#define SMC_GET_MAC_ADDR(addr) \
    > + do { \
    > + unsigned int __v; \
    > + __v = SMC_inw( ioaddr, ADDR0_REG ); \
    > + addr[0] = __v; addr[1] = __v >> 8; \
    > + __v = SMC_inw( ioaddr, ADDR1_REG ); \
    > + addr[2] = __v; addr[3] = __v >> 8; \
    > + __v = SMC_inw( ioaddr, ADDR2_REG ); \
    > + addr[4] = __v; addr[5] = __v >> 8; \
    > + if (*(u32 *)(&addr[0]) == 0xFFFFFFFF) { \
    > + random_ether_addr(addr); \
    > + } \
    > + } while (0)

    Please follow kernel coding style:

    __v = SMC_inw(ioaddr, ADDR2_REG);


    Can this not be implemented as a C function?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-01 09:57    [W:0.024 / U:29.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site