lkml.org 
[lkml]   [2007]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix get_unmapped_area and fsync for hugetlb shm segments
    On Thu, Mar 01, 2007 at 03:46:08PM -0800, Adam Litke wrote:
    > static inline int is_file_hugepages(struct file *file)
    > {
    > - return file->f_op == &hugetlbfs_file_operations;
    > + if (file->f_op == &hugetlbfs_file_operations)
    > + return 1;
    > + if (is_file_shm_hugepages(file))
    > + return 1;
    > +
    > + return 0;
    > }
    ...
    > +int is_file_shm_hugepages(struct file *file)
    > +{
    > + int ret = 0;
    > +
    > + if (file->f_op == &shm_file_operations) {
    > + struct shm_file_data *sfd;
    > + sfd = shm_file_data(file);
    > + ret = is_file_hugepages(sfd->file);
    > + }
    > + return ret;

    A comment to prepare others for the impending doubletake might be nice.
    Or maybe just open-coding the equality check for &huetlbfs_file_operations
    in is_file_shm_hugepages() if others find it as jarring as I. Please
    extend my ack to any follow-up fiddling with that.

    The patch addresses relatively straightforward issues and naturally at
    that.

    Acked-by: William Irwin <bill.irwin@oracle.com>


    -- wli
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-03-02 01:31    [W:2.903 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site