Messages in this thread | | | Date | Thu, 1 Mar 2007 19:03:02 -0500 | From | "Mike Frysinger" <> | Subject | should RTS init in serial core be tied to CRTSCTS |
| |
the console= bootcmd allows for controlling of the initial state of flow control by adding/omitting the 'r' suffix ... however, the uart_startup() function in serial_core.c always calls down into the serial driver with TIOCM_RTS: static int uart_startup(...) { ... /* * Setup the RTS and DTR signals once the * port is open and ready to respond. */ if (info->tty->termios->c_cflag & CBAUD) uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR); ...
shouldnt TIOCM_RTS be passed down only when the 'r' is appended to the boot cmdline ? perhaps like this: uart_set_mctrl(port, (info->flags & UIF_CTS_FLOW ? TIOCM_RTS : 0) | TIOCM_DTR); assuming too that TIOCM_DTR should always be set ... -mike - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |