Messages in this thread |  | | Date | Fri, 9 Feb 2007 01:35:18 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 6/10] lguest code: the little linux hypervisor. |
| |
On Fri, 09 Feb 2007 20:20:27 +1100 Rusty Russell <rusty@rustcorp.com.au> wrote:
> +#define log(...) \ > + do { \ > + mm_segment_t oldfs = get_fs(); \ > + char buf[100]; \ > + sprintf(buf, "lguest:" __VA_ARGS__); \ > + set_fs(KERNEL_DS); \ > + sys_write(1, buf, strlen(buf)); \ > + set_fs(oldfs); \ > + } while(0)
Due to gcc shortcomings, each instance of this will chew an additional 100 bytes of stack. Unless they fixed it recently. Is a bit of a timebomb. I guess ksaprintf() could be used.
It also looks a bit, umm, innovative. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |