lkml.org 
[lkml]   [2007]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 6c/10] lguest: the guest code
    Date
    On Friday 09 February 2007 12:14, James Morris wrote:
    > On Fri, 9 Feb 2007, Len Brown wrote:
    >
    > > On Friday 09 February 2007 05:57, Rusty Russell wrote:
    > >
    > > > +#ifdef CONFIG_ACPI
    > > > +       acpi_disabled = 1;
    > > > +       acpi_ht = 0;
    > > > +#endif
    > >
    > > If this is hard-coded to have ACPI disabled, why isn't it enforced at build-time?
    >
    > This is being disabled in the guest kernel only. The host and guest
    > kernels are expected to be the same build.

    Okay, but better to use disable_acpi()
    indeed, since this would be the first code not already inside CONFIG_ACPI
    to invoke disable_acpi(), we could define the inline as empty and you could
    then scratch the #ifdef too.

    cheers,
    -Len
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-09 18:53    [W:3.727 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site