Messages in this thread |  | | Date | Fri, 09 Feb 2007 17:02:26 +0100 | From | Stefan Richter <> | Subject | Re: Coding style question |
| |
Pavel Pisa wrote: > There are tightly copled two macros for preparation > and acquisition of muti-bit masked fields values > > #define __val2mfld(mask,val) (((mask)&~((mask)<<1))*(val)&(mask)) > > #define __mfld2val(mask,val) (((val)&(mask))/((mask)&~((mask)<<1)))
The macro names are awkward. http://lxr.linux.no/source/Documentation/CodingStyle?v=2.6.18#L133
Consider longer names (and to partially counteract column consumption, omit the leading underscores) or at least spell their purpose out in a short comment at the macro definitions. -- Stefan Richter -=====-=-=== --=- -=--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |