Messages in this thread | | | Date | Thu, 8 Feb 2007 23:05:48 +0100 | From | Sam Ravnborg <> | Subject | Re: The who needs reviews anyways [PATCH] |
| |
On Thu, Feb 08, 2007 at 10:48:51PM +0100, Roman Zippel wrote: > Hi, > > This adds the remaining changes which should have been part of the review > process. Oleg could have learned something in process, but who needs that > if wasting everyones time is so much more fun... > > Sorry for the delay, but the git server were gone. > > - the define command is inappropriate (it's primarily for rule > definitions) > - execute commands in the current dir as all other commands > - .*.tmp (but not .*.null) files are also removed up by "make clean" > - printf has other side effects, instead stop pretending we support > something else than bash > - proper quoting > - proper indentation > > bye, Roman > > Signed-off-by: Roman Zippel <zippel@linux-m68k.org> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked as "patch reviewed and looks good".
PS. Will be unresponsive for next 12 days due to vacation.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |