lkml.org 
[lkml]   [2007]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch] i386/x86_64: smp_call_function locking inconsistency
From
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Date: Thu, 8 Feb 2007 21:32:10 +0100

> So either all spin_lock_bh's should be converted to spin_lock,
> which would limit smp_call_function()/smp_call_function_single()
> to process context & irqs enabled.
> Or the spin_lock's could be converted to spin_lock_bh which would
> make it possible to call these two functions even if in softirq
> context. AFAICS this should be safe.

Sparc64 does not allow smp_call_function() from software interrupts
either.

Same for powerpc, mips, alpha.

IA-64 has the inconsistency you've spotted between smp_call_function()
and smp_call_function_single().

In short, it's a mess :-)

I think it's logically simpler if we disallow smp_call_function*()
from any kind of asynchronous context. But I'm sure your driver
has a true need for this for some reason.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-08 21:47    [W:2.359 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site