lkml.org 
[lkml]   [2007]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fw: [BUG][PATCH] fix mempolcy's check on a system with memory-less-node take3
On Thu, 8 Feb 2007, KAMEZAWA Hiroyuki wrote:

> @@ -162,6 +162,10 @@
> break;
> k--;
> }
> + if (!num) {
> + kfree(zl);
> + return ERR_PTR(-EINVAL);
> + }
> zl->zones[num] = NULL;
> return zl;
> }

Ok. So you are detecting a set of nodes that has nodes specified but the
zones that these nodes refer to are empty, as an error.

Should work.

> @@ -193,9 +197,11 @@
> break;
> case MPOL_BIND:
> policy->v.zonelist = bind_zonelist(nodes);
> - if (policy->v.zonelist == NULL) {
> + if (IS_ERR(policy->v.zonelist)) {
> + void *val = policy->v.zonelist;
> + policy->v.zonelist = NULL;

void *? Ahh. It takes the error code.

Looks good. But if we are really going down this road of memory-less
nodes we may want to audit the kernel for other issues.

Could you run a series of tests on that machine?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-08 20:31    [W:0.074 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site