lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/28] driver core: Remove device_is_registered() in device_move().
    Date
    From: Cornelia Huck <cornelia.huck@de.ibm.com>

    device_is_registered() will always be false for a device with no bus. Remove
    this check and trust the caller to know what they're doing.

    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Cc: Marcel Holtmann <marcel@holtmann.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/base/core.c | 4 ----
    1 files changed, 0 insertions(+), 4 deletions(-)

    diff --git a/drivers/base/core.c b/drivers/base/core.c
    index 67b79a7..36eedfd 100644
    --- a/drivers/base/core.c
    +++ b/drivers/base/core.c
    @@ -1004,10 +1004,6 @@ int device_move(struct device *dev, struct device *new_parent)
    if (!dev)
    return -EINVAL;

    - if (!device_is_registered(dev)) {
    - error = -EINVAL;
    - goto out;
    - }
    new_parent = get_device(new_parent);
    if (!new_parent) {
    error = -EINVAL;
    --
    1.4.4.4
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-08 01:55    [W:0.047 / U:177.768 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site