[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] Define the shmem_inode_info flags directly

Andrew: This is a pretty basic and obvious cleanup IMO. How about a ride in

Defining flags in terms of other flags is always confusing. Give them literal
values instead of defining them in terms of VM_flags. While we're at it, move
them to a header file in preparation for the introduction of a

Signed-off-by: Adam Litke <>

include/linux/shmem_fs.h | 4 ++++
mm/shmem.c | 4 ----
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h
index f3c5189..3ea0b6e 100644
--- a/include/linux/shmem_fs.h
+++ b/include/linux/shmem_fs.h
@@ -8,6 +8,10 @@

#define SHMEM_NR_DIRECT 16

+/* These info->flags are used to handle pagein/truncate races efficiently */
+#define SHMEM_PAGEIN 0x00000001
+#define SHMEM_TRUNCATE 0x00000002
struct shmem_inode_info {
spinlock_t lock;
unsigned long flags;
diff --git a/mm/shmem.c b/mm/shmem.c
index 70da7a0..a9bdb0d 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -66,10 +66,6 @@

#define VM_ACCT(size) (PAGE_CACHE_ALIGN(size) >> PAGE_SHIFT)

-/* info->flags needs VM_flags to handle pagein/truncate races efficiently */
/* Definition to limit shmem_truncate's steps between cond_rescheds */
#define LATENCY_LIMIT 64

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at
 \ /
  Last update: 2007-02-07 21:43    [W:0.031 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site