lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] FS : Speedup rw_verify_area()
    Date
    oprofile hunting showed a stall in rw_verify_area(), because of triple 
    indirection and potential cache misses.
    (file->f_path.dentry->d_inode->i_flock)

    By moving initialization of 'struct inode' pointer before the pos/count sanity
    tests, we allow the compiler and processor to perform two loads by
    anticipation, reducing stall, without prefetch() hints. Even x86 arch has
    enough registers to not use temporary variables and not increase text size.

    I validated this patch running a bench and studied oprofile changes, and
    absolute perf of the test program.

    Results of my epoll_pipe_bench (source available on request) on a Pentium-M
    1.6 GHz machine

    Before :
    # ./epoll_pipe_bench -l 30 -t 20
    Avg: 436089 evts/sec read_count=8843037 write_count=8843040 21.218390 samples
    per call
    (best value out of 10 runs)

    After :
    # ./epoll_pipe_bench -l 30 -t 20
    Avg: 470980 evts/sec read_count=9549871 write_count=9549894 21.216694 samples
    per call
    (best value out of 10 runs)

    oprofile CPU_CLK_UNHALTED events gave a reduction from 5.3401 % to 2.5851 %
    for the rw_verify_area() function.

    Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
    --- linux-2.6.20/fs/read_write.c 2007-02-07 18:21:59.000000000 +0100
    +++ linux-2.6.20-ed/fs/read_write.c 2007-02-07 18:23:41.000000000 +0100
    @@ -197,13 +197,13 @@ int rw_verify_area(int read_write, struc
    struct inode *inode;
    loff_t pos;

    + inode = file->f_path.dentry->d_inode;
    if (unlikely((ssize_t) count < 0))
    goto Einval;
    pos = *ppos;
    if (unlikely((pos < 0) || (loff_t) (pos + count) < 0))
    goto Einval;

    - inode = file->f_path.dentry->d_inode;
    if (unlikely(inode->i_flock && MANDATORY_LOCK(inode))) {
    int retval = locks_mandatory_area(
    read_write == READ ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE,
    \
     
     \ /
      Last update: 2007-02-07 19:19    [W:0.053 / U:121.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site