Messages in this thread | | | Date | Wed, 7 Feb 2007 15:36:47 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [patch 2/3, resend] kbuild: improve option checking, Kbuild.include cleanup |
| |
Hi,
On Tue, 6 Feb 2007, Oleg Verych wrote:
> -- all checks by shell united in one macro -- checker-shell; > -- one disposable output sym. link to /dev/null per shell, > thus no racing, `-Z' is removed; > -- modules' build output directory is used, if supplied; > -- every option checking function calls shell wrapper, acquires probe; > -- `echo -e' bashizm substituted (people with sh != bash have distinct > CC options!); > -- some spelling and sense added to the comments; > -- small shuffle of whitespace.
This patch is a bit overloaded and it would be better to split it up to keep functional changes separate and then please drop the symlink, it has no advantage to a simple temp file. Also please don't add random whitespace, Makefiles are no C files, so different rules apply.
bye, Roman
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |