lkml.org 
[lkml]   [2007]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mfd: SM501 core driver
    On Wed, Feb 07, 2007 at 11:48:25AM +0000, Ben Dooks wrote:
    > On Tue, Feb 06, 2007 at 09:09:30PM -0800, Andrew Morton wrote:
    > > On Tue, 6 Feb 2007 19:26:28 +0000 Ben Dooks <ben-linux@fluff.org> wrote:
    > > > +/* sm501_null_release
    > > > + *
    > > > + * A release function for the platform devices we create to keep the
    > > > + * driver core happy, and stop any crashed when the devices are removed
    > > > +*/
    > > > +
    > > > +static void sm501_null_release(struct device *dev)
    > > > +{
    > > > +}
    > >
    > > Greg might have an opinion on that ;)
    >
    > Without this the system OOPses when the driver is removed.

    Are you sure about that? And it's not just an error message being
    printed out telling you that you must provide a release function?

    And BIG hint, providing an empty release function just to shut up the
    kernel is NOT a fix. You really need to free your memory here, not just
    ignore it.

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-07 15:27    [W:0.022 / U:0.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site