Messages in this thread | | | Date | Wed, 7 Feb 2007 14:02:27 +0100 | Subject | Re: [patch 1/3, resend] scripts: replace gawk, head, bc with shell, update | From | Oleg Verych <> |
| |
On Wed, Feb 07, 2007 at 09:58:12AM +0100, Jesper Juhl wrote: > On 06/02/07, Oleg Verych <olecom@flower.upol.cz> wrote: > >scripts: replace gawk, head, bc with shell, update > > > > Replacing overhead of using some (external) programs > > instead of good old `sh'. > > > >Cc: Roman Zippel <zippel@linux-m68k.org> > >Cc: Sam Ravnborg <sam@ravnborg.org> > >Cc: William Stearns <wstearns@pobox.com> > >Cc: Martin Schlemmer <azarah@nosferatu.za.org> > >Signed-off-by: Oleg Verych <olecom@flower.upol.cz> > >--- > > > > Whitespace cleanup included. > > > > scripts/gen_initramfs_list.sh | 43 > > +++++++++++++++++++++--------------------- > > scripts/makelst | 34 ++++++++++++++++----------------- > > 2 files changed, 39 insertions(+), 38 deletions(-) > > > >Index: linux-2.6.20/scripts/makelst > >=================================================================== > >--- linux-2.6.20.orig/scripts/makelst 2007-02-06 02:12:38.811908000 +0100 > >+++ linux-2.6.20/scripts/makelst 2007-02-06 02:12:43.688212750 +0100 > >@@ -1,31 +1,31 @@ > >-#!/bin/bash > >+#!/bin/sh > > I don't like this change much. We don't know what shell /bin/sh is on > a random users system - much better to be explicit and make sure we > use/require bash. > I expect this change to cause pain for users who have zsh, csh, ksh, > ash or some other shell as /bin/sh but also have /bin/bash available. > Previously things would just work, but now it will possibly break due > to using a different shell.
I've tested on dash, that is `sh'. Everybody is welcome to test on his favorite `/bin/sh' compatible shell.
It's very unclear from bash man page, where are extentions, and where are common features. That particular script is small and non-bash oriented, unlike gen_initramfs_list.sh [s/sh/bash].
Thus it's OK, even in scope of SUSv3 "incompatible" "%ul" in `printf' (see my other reply on that).
____ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |