Messages in this thread |  | | Date | Tue, 06 Feb 2007 16:22:51 -0800 | From | Zachary Amsden <> | Subject | Re: [PATCH 6/11] Vmi timer no idle hz fixes.patch |
| |
Andi Kleen wrote: >> -#ifdef CONFIG_S390 >> -#ifdef CONFIG_MATHEMU >> - { >> - .ctl_name = KERN_IEEE_EMULATION_WARNINGS, >> - .procname = "ieee_emulation_warnings", >> - .data = &sysctl_ieee_emulation_warnings, >> - .maxlen = sizeof(int), >> - .mode = 0644, >> - .proc_handler = &proc_dointvec, >> - }, >> > > I think there needs to be a way to have this syctl only > when it's really implemented for the paravirt ops. > > I suppose you should move it to dynamic registration on demand. >
Hmm, is there a way to do that and share the sysctl with Xen? Yes, I think if we move the data to paravirt.c and call paravirt_start_no_idle_hz (or something_with_fewer_underbars), then we can both share this call site instead of silly duplicating the .ctl_name ...
Will code it up.
Zach - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |