lkml.org 
[lkml]   [2007]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/2] x86_64 irq: Handle irqs pending in IRR during irq migration.
    Date
    "Lu, Yinghai" <yinghai.lu@amd.com> writes:

    > From: ebiederm@xmission.com [mailto:ebiederm@xmission.com]
    >>> How about let apic_hangle_pending_vector take the irq too?
    >
    >>We can't compute the vector by reading the hardware registers after
    >>we have acknowledged the irq.
    >
    >>I hope that was the answer you were looking for I'm not quite certain
    >>what you mean by take.
    >
    > I mean

    I don't see the point. We would have to miscompute the vector that
    we are servicing or improperly fill in vector_irq for that to be useful.

    The only corner case I can see that might potentially happen is
    "apic_in_service_vector() != irq_vector[irq]" and if that is the case
    we don't want to migrate, because the precondition that we are in the
    irq handler servicing the expected irq isn't true.

    Of course someone would have to set IRQ_MOVE_PENDING pretty fast for
    that case to hit, it's a tiny hole probably worth closing though.

    Eric

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-05 21:41    [W:3.205 / U:1.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site