Messages in this thread |  | | Date | Sat, 3 Feb 2007 08:09:32 -0800 | From | Greg KH <> | Subject | Re: [PATCH] drivers/isdn/gigaset: new M101 driver |
| |
On Thu, Feb 01, 2007 at 05:13:45PM -0800, Andrew Morton wrote: > > +/* dummy to shut up framework warning */ > > +static void gigaset_device_release(struct device *dev) > > +{ > > + //FIXME anything to do? cf. platform_device_release() > > +} > > Ask Greg ;)
Oh come on people. Don't provide an empty function because the kernel is complaining that you don't provide a release function. Yes it will shut the kernel up but did you ever think _why_ the kernel was complaining? Did you think it did it just for fun?
Think people, think...
You need to free your memory here, don't just provide an empty function, that shows the driver is broken.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |