[lkml]   [2007]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 1/9] fs: libfs buffered write leak fix
On Sat, Feb 03, 2007 at 05:49:47PM +0000, Jörn Engel wrote:
> On Sat, 3 February 2007 02:33:16 +0100, Nick Piggin wrote:
> >
> > If doing a partial-write, simply clear the whole page and set it uptodate
> > (don't need to get too tricky).
> That sounds just like a bug I recently fixed in logfs. prepare_write()
> would clear the page, commit_write() would write the whole page. Bug
> can be reproduced with a simple testcate:
> echo -n foo > foo
> echo -n bar >> foo
> cat foo
> With the bug, the second write will replace "foo" with "\0\0\0" and
> cat will return "bar". Doing a read instead of clearing the page will
> return "foobar", as would be expected.
> Can you hit the same bug with your patch or did I miss something?

Yes, the page is only cleared if it is not uptodate. This is fine
for the simple filesystems.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-02-04 04:59    [W:0.081 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site