Messages in this thread | | | Date | Wed, 28 Feb 2007 23:35:15 +0300 | From | Oleg Nesterov <> | Subject | Re: Problem with freezable workqueues |
| |
On 02/28, Rafael J. Wysocki wrote: > > Okay, but I've just finished the patch that removes the freezability of > workqueues (appended), so can we please do this in a separate one?
Please, please, no. This patch is of course correct, but it breaks _a lot_ of patches in -mm tree.
May I ask you to send just
> =================================================================== > --- linux-2.6.21-rc2.orig/fs/xfs/linux-2.6/xfs_buf.c > +++ linux-2.6.21-rc2/fs/xfs/linux-2.6/xfs_buf.c > @@ -1829,11 +1829,11 @@ xfs_buf_init(void) > if (!xfs_buf_zone) > goto out_free_trace_buf; > > - xfslogd_workqueue = create_freezeable_workqueue("xfslogd"); > + xfslogd_workqueue = create_workqueue("xfslogd"); > if (!xfslogd_workqueue) > goto out_free_buf_zone; > > - xfsdatad_workqueue = create_freezeable_workqueue("xfsdatad"); > + xfsdatad_workqueue = create_workqueue("xfsdatad"); > if (!xfsdatad_workqueue) > goto out_destroy_xfslogd_workqueue; > >
this bit?
After that, we can do the "removes the freezability of workqueues" patch against -mm tree.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |