lkml.org 
[lkml]   [2007]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/7] cxgb3 - FW version update
Steve Wise wrote:
> Hey Divy,
>
> You missed a printk change. Here is an updated patch.
>
> ------------
>
> Update FW version to 3.2
>
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> ---
>
> drivers/net/cxgb3/t3_hw.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/cxgb3/t3_hw.c b/drivers/net/cxgb3/t3_hw.c
> index 365a7f5..08a6295 100644
> --- a/drivers/net/cxgb3/t3_hw.c
> +++ b/drivers/net/cxgb3/t3_hw.c
> @@ -884,11 +884,11 @@ int t3_check_fw_version(struct adapter *
> major = G_FW_VERSION_MAJOR(vers);
> minor = G_FW_VERSION_MINOR(vers);
>
> - if (type == FW_VERSION_T3 && major == 3 && minor == 1)
> + if (type == FW_VERSION_T3 && major == 3 && minor == 2)
> return 0;
>
> CH_ERR(adapter, "found wrong FW version(%u.%u), "
> - "driver needs version 3.1\n", major, minor);
> + "driver needs version 3.2\n", major, minor);

I would rather fix the code to use constants, and thus avoid this
problem ever happening again.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-25 20:53    [W:0.051 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site