lkml.org 
[lkml]   [2007]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] sata_nv: complain on spurious completion notifiers
    Recently Tejun wrote a patch to ahci.c to make it raise a HSM violation
    if the drive attempted to complete a tag that wasn't outstanding. We could
    run into the same problem with sata_nv ADMA. This adds code to raise a HSM
    violation error if the controller gives us a notifier tag that isn't
    outstanding, since the drive may be issuing spurious completions.

    Signed-off-by: Robert Hancock <hancockr@shaw.ca>

    --- linux-2.6.21-rc1edit/drivers/ata/sata_nv.c.prev 2007-02-21 22:17:31.000000000 -0600
    +++ linux-2.6.21-rc1edit/drivers/ata/sata_nv.c 2007-02-21 22:22:14.000000000 -0600
    @@ -740,6 +740,17 @@ static int nv_adma_check_cpb(struct ata_
    DPRINTK("Completing qc from tag %d with err_mask %u\n",cpb_num,
    qc->err_mask);
    ata_qc_complete(qc);
    + } else {
    + struct ata_eh_info *ehi = &ap->eh_info;
    + /* Notifier bits set without a command may indicate the drive
    + is misbehaving. Raise host state machine violation on this
    + condition. */
    + ata_port_printk(ap, KERN_ERR, "notifier for tag %d with no command?\n",
    + cpb_num);
    + ehi->err_mask |= AC_ERR_HSM;
    + ehi->action |= ATA_EH_SOFTRESET;
    + ata_port_freeze(ap);
    + return 1;
    }
    }
    return 0;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-22 06:57    [W:1.483 / U:30.832 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site