lkml.org 
[lkml]   [2007]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] cxgb3 - private ioctl cleanup
Hi Yoshfuji,
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> Clean up some private ioctls.
>>
>> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>> ---
>>
>> drivers/net/cxgb3/cxgb3_ioctl.h | 21 ++++-------------
>> drivers/net/cxgb3/cxgb3_main.c | 48 +++------------------------------------
>> 2 files changed, 9 insertions(+), 60 deletions(-)
>>
>> diff --git a/drivers/net/cxgb3/cxgb3_ioctl.h b/drivers/net/cxgb3/cxgb3_ioctl.h
>> index a942818..42d4bf6 100644
>> --- a/drivers/net/cxgb3/cxgb3_ioctl.h
>> +++ b/drivers/net/cxgb3/cxgb3_ioctl.h
>> @@ -36,28 +36,17 @@
>> * Ioctl commands specific to this driver.
>> */
>> enum {
>> - CHELSIO_SETREG = 1024,
>> - CHELSIO_GETREG,
>> - CHELSIO_SETTPI,
>> - CHELSIO_GETTPI,
>> - CHELSIO_GETMTUTAB,
>> + CHELSIO_GETMTUTAB = 1024,
>> CHELSIO_SETMTUTAB,
>> - CHELSIO_GETMTU,
>> - CHELSIO_SET_PM,
>> - CHELSIO_GET_PM,
>> - CHELSIO_GET_TCAM,
>> - CHELSIO_SET_TCAM,
>> - CHELSIO_GET_TCB,
>> CHELSIO_GET_MEM,
>> CHELSIO_LOAD_FW,
>> - CHELSIO_GET_PROTO,
>> - CHELSIO_SET_PROTO,
>> CHELSIO_SET_TRACE_FILTER,
>> - CHELSIO_SET_QSET_PARAMS,
>> CHELSIO_GET_QSET_PARAMS,
>> - CHELSIO_SET_QSET_NUM,
>> + CHELSIO_SET_QSET_PARAMS,
>> CHELSIO_GET_QSET_NUM,
>> - CHELSIO_SET_PKTSCHED,
>> + CHELSIO_SET_QSET_NUM,
>> + CHELSIO_GET_PM,
>> + CHELSIO_SET_PM,
>> };
>>
>>
>
> I disagree. This is very bad.
>
> 1. Please do do change the values.
> 2. Explain why you are going to kill these ioctls.
>
Jeff and Arjan have required that most of these ioctls go.
Please read:
http://marc.theaimsgroup.com/?l=linux-netdev&m=117029584904193&w=2

Cheers,
Divy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-22 13:37    [W:0.034 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site