lkml.org 
[lkml]   [2007]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 006 of 6] md: Add support for reshape of a raid6
    Date
    On Thursday, 22 February 2007 00:58, Andrew Morton wrote:
    > On Thu, 22 Feb 2007 00:36:22 +0100
    > Oleg Verych <olecom@flower.upol.cz> wrote:
    >
    > > > From: Andrew Morton
    > > > Newsgroups: gmane.linux.raid,gmane.linux.kernel
    > > > Subject: Re: [PATCH 006 of 6] md: Add support for reshape of a raid6
    > > > Date: Wed, 21 Feb 2007 14:48:06 -0800
    > >
    > > Hallo.
    > >
    > > > On Tue, 20 Feb 2007 17:35:16 +1100
    > > > NeilBrown <neilb@suse.de> wrote:
    > > >
    > > >> + for (i = conf->raid_disks ; i-- ; ) {
    > > >
    > > > That statement should be dragged out, shot, stomped on then ceremonially
    > > > incinerated.
    > > >
    > > > What's wrong with doing
    > > >
    > > > for (i = 0; i < conf->raid_disks; i++) {
    > > >
    > > > in a manner which can be understood without alcoholic fortification?
    > > >
    > > > ho hum.
    > >
    > > In case someone likes to do job, GCC usually ought to do, i would
    > > suggest something like this instead:
    > >
    > > if (expanded && test_bit(STRIPE_EXPANDING, &sh->state)) {
    > > /* Need to write out all blocks after computing P&Q */
    > > - sh->disks = conf->raid_disks;
    > > + i = conf->raid_disks;
    > > + sh->disks = i;
    > > - sh->pd_idx = stripe_to_pdidx(sh->sector, conf,
    > > - conf->raid_disks);
    > > + sh->pd_idx = stripe_to_pdidx(sh->sector, conf, i);
    > >
    > > compute_parity6(sh, RECONSTRUCT_WRITE);
    > > - for (i = conf->raid_disks ; i-- ; ) {
    > > + do {
    > > set_bit(R5_LOCKED, &sh->dev[i].flags);
    > > locked++;
    > > set_bit(R5_Wantwrite, &sh->dev[i].flags);
    > > - }
    > > + } while (--i);
    > >
    > > clear_bit(STRIPE_EXPANDING, &sh->state);
    > > } else if (expanded) {
    > >
    > > In any case this is subject of scripts/bloat-o-meter.
    >
    > This:
    >
    > --- a/drivers/md/raid5.c~a
    > +++ a/drivers/md/raid5.c
    > @@ -2364,7 +2364,7 @@ static void handle_stripe6(struct stripe
    > sh->pd_idx = stripe_to_pdidx(sh->sector, conf,
    > conf->raid_disks);
    > compute_parity6(sh, RECONSTRUCT_WRITE);
    > - for (i = conf->raid_disks ; i-- ; ) {
    > + for (i = 0; i < conf->raid_disks; ++) {

    I guess it should be

    + for (i = 0; i < conf->raid_disks; i++)

    > set_bit(R5_LOCKED, &sh->dev[i].flags);
    > locked++;
    > set_bit(R5_Wantwrite, &sh->dev[i].flags);
    > _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-22 01:07    [W:0.024 / U:59.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site