Messages in this thread | | | Date | Wed, 21 Feb 2007 17:23:42 +0300 | From | Oleg Nesterov <> | Subject | Re: [PATCH] net/bridge/br_if.c: fix possible use-after-free in port_carrier_check() |
| |
On 02/21, Jarek Poplawski wrote: > > > On Wed, 21 Feb 2007 01:19:41 +0300 > > Oleg Nesterov <oleg@tv-sign.ru> wrote: > > > > > + p = container_of(work, struct net_bridge_port, carrier_check.work); > > > > > > rtnl_lock(); > > > - p = dev->br_port; > > > - if (!p) > > > - goto done; > > > br = p->br; > > It doesn't matter very much but I think this would look > better after the first if check.
OK. I can re-send if this patch is otherwise correct.
Oleg.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |