Messages in this thread | | | From | David Howells <> | Subject | Re: PATCH? net/bridge/br_if.c: fix use after free in port_carrier_check() | Date | Tue, 20 Feb 2007 10:44:56 +0000 |
| |
Oleg Nesterov <oleg@tv-sign.ru> wrote:
> static void release_nbp(struct kobject *kobj) > { > struct net_bridge_port *p > = container_of(kobj, struct net_bridge_port, kobj); > + > + dev_put(p->dev);
Does this need to be done with the mutex held? And does anything actually pay attention to the refcount on dev? I assume not...
Should you clear p->dev->br_port before calling dev_put()?
Looks reasonable. I like it.
Acked-By: David Howells <dhowells@redhat.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |