Messages in this thread |  | | Date | Tue, 20 Feb 2007 13:31:32 -0800 | From | Stephen Hemminger <> | Subject | Re: 2.6.19-rc6-mm1: drivers/net/chelsio/: unused code |
| |
On Tue, 20 Feb 2007 01:02:14 +0100 Adrian Bunk <bunk@stusta.de> wrote:
> On Tue, Nov 28, 2006 at 11:47:19PM -0800, Andrew Morton wrote: > > On Wed, 29 Nov 2006 08:36:09 +0100 > > Adrian Bunk <bunk@stusta.de> wrote: > > > > > On Mon, Nov 27, 2006 at 10:24:55AM -0800, Stephen Hemminger wrote: > > > > On Fri, 24 Nov 2006 01:17:31 +0100 > > > > Adrian Bunk <bunk@stusta.de> wrote: > > > > > > > > > On Thu, Nov 23, 2006 at 02:17:03AM -0800, Andrew Morton wrote: > > > > > >... > > > > > > Changes since 2.6.19-rc5-mm2: > > > > > >... > > > > > > +chelsio-22-driver.patch > > > > > >... > > > > > > netdev updates > > > > > > > > > > It is suspicious that the following newly added code is completely unused: > > > > > drivers/net/chelsio/ixf1010.o > > > > > t1_ixf1010_ops > > > > > drivers/net/chelsio/mac.o > > > > > t1_chelsio_mac_ops > > > > > drivers/net/chelsio/vsc8244.o > > > > > t1_vsc8244_ops > > > > > > > > > > cu > > > > > Adrian > > > > > > > > > > > > > All that is gone in later version. I reposted new patches > > > > after -mm2 was done. > > > > > > It seems these patches didn't make it into 2.6.19-rc6-mm2 ? > > > > I dropped that patch and picked up Francois's tree instead. > > These structs are still both present and unused as of 2.6.20-mm1.
Please use your eyes, not your tool. Those functions are called in 2.6.20
static struct cmac *ixf1010_mac_create(adapter_t *adapter, int index) { ... mac->ops = &ixf1010_ops;
static struct cmac *mac_create(adapter_t *adapter, int index) { ...
mac->ops = &chelsio_mac_ops;
mac_create gets called by
int __devinit t1_init_sw_modules(adapter_t *adapter, const struct board_info *bi) {
for_each_port(adapter, i) { u8 hw_addr[6]; struct cmac *mac; int phy_addr = bi->mdio_phybaseaddr + i;
adapter->port[i].phy = bi->gphy->create(adapter, phy_addr, bi->mdio_ops);
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |