lkml.org 
[lkml]   [2007]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pata_sl82c105: remove un-needed code paths
Alan wrote:
> Remove the DMA setup function. As pointed out by Sergey we set the actual
> DMA clock timing in set_dmamode so we don't actually need to do anything
> with it at set up time, but just leave the PIO timings loaded.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-mm2/drivers/ata/pata_sl82c105.c linux-2.6.20-mm2/drivers/ata/pata_sl82c105.c
> --- linux.vanilla-2.6.20-mm2/drivers/ata/pata_sl82c105.c 2007-02-20 13:37:58.000000000 +0000
> +++ linux-2.6.20-mm2/drivers/ata/pata_sl82c105.c 2007-02-20 13:58:10.000000000 +0000
> @@ -7,6 +7,13 @@
> * SL82C105/Winbond 553 IDE driver
> *
> * and in part on the documentation and errata sheet
> + *
> + *
> + * Note: The controller like many controllers has shared timings for
> + * PIO and DMA. We thus flip to the DMA timings in dma_start and flip back
> + * in the dma_stop function. Thus we actually don't need a set_dmamode
> + * method as the PIO method is always called and will set the right PIO
> + * timing parameters.
> */
>
> #include <linux/kernel.h>
> @@ -19,7 +26,7 @@
> #include <linux/libata.h>
>
> #define DRV_NAME "pata_sl82c105"
> -#define DRV_VERSION "0.2.3"
> +#define DRV_VERSION "0.2.5"

applied

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-20 17:57    [W:0.019 / U:2.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site