Messages in this thread | | | Subject | Re: [PATCH 05/44 take 2] [UBI] internal common header | From | Artem Bityutskiy <> | Date | Tue, 20 Feb 2007 17:24:15 +0200 |
| |
On Tue, 2007-02-20 at 15:15 +0000, David Woodhouse wrote: > On Tue, 2007-02-20 at 09:55 -0500, Theodore Tso wrote: > > It appears that the reason why you are doing this is because you think > > you need the (packed) attribute. Not needed; Linux assumes all over > > the place 16, 32, and 64 types are packed. If Linux is ever compiled > > on an architecture where this isn't true, the compiler will probably > > need to be fixed so these assumptions are true, since all manner of > > things will break. > > No, the packedness is irrelevant -- the reason is just to catch all the > places where you might otherwise forget to use byte-swapping accesses.
Bear in mind we share this header with user-space, so it is safer to use packed as well as C99 types.
-- Best regards, Artem Bityutskiy (Битюцкий Артём)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |