[lkml]   [2007]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 45/59] bonding: ARP monitoring broken on x86_64
-stable review patch.  If anyone has any objections, please let us know.
From: Andy Gospodarek <>

While working with the latest bonding code I noticed a nasty problem that
will prevent arp monitoring from always functioning correctly on x86_64
systems. Comparing ints to longs and expecting reliable results on x86_64
is a bad idea. With this patch, arp monitoring works correctly again.

Signed-off-by: Andy Gospodarek <>
Cc: "David S. Miller" <>
Cc: Stephen Hemminger <>
Cc: Jeff Garzik <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Jeff Garzik <>
Signed-off-by: Chris Wright <>
drivers/net/bonding/bonding.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- linux-
+++ linux-
@@ -151,8 +151,8 @@ struct slave {
struct slave *next;
struct slave *prev;
int delay;
- u32 jiffies;
- u32 last_arp_rx;
+ unsigned long jiffies;
+ unsigned long last_arp_rx;
s8 link; /* one of BOND_LINK_XXXX */
s8 state; /* one of BOND_STATE_XXXX */
u32 original_flags;
@@ -242,7 +242,8 @@ extern inline int slave_do_arp_validate(
return bond->params.arp_validate & (1 << slave->state);

-extern inline u32 slave_last_rx(struct bonding *bond, struct slave *slave)
+extern inline unsigned long slave_last_rx(struct bonding *bond,
+ struct slave *slave)
if (slave_do_arp_validate(bond, slave))
return slave->last_arp_rx;
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-02-03 03:45    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean