lkml.org 
[lkml]   [2007]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 05/44 take 2] [UBI] internal common header
    From
    Date
    On Sat, 2007-02-17 at 22:05 +0100, Arnd Bergmann wrote:
    > > +/* Maximum number of supported UBI devices */
    > > +#define UBI_MAX_INSTANCES 32
    >
    > Does this need to be limited?

    It is how this is implemented at the moment. Note, this limits number of
    UBI devices, not ubi _volumes_.

    > > +/* UBI error messages */
    > > +#define ubi_err(fmt, ...) \
    > > + printk(UBI_ERR_LEVEL UBI_ERR_PREF " %s " fmt "\n", __FUNCTION__, \
    > > + ##__VA_ARGS__)
    >
    > You shouldn't need these helpers, just use the regular dev_dbg, dev_info
    > and related macros.

    I will look at them and see if they are ok.

    > > +struct ubi_info {
    > > + int ubi_num;
    > > + struct ubi_io_info *io;
    > > + struct ubi_bgt_info *bgt;
    > > + struct ubi_wl_info *wl;
    > > + struct ubi_beb_info *beb;
    > > + struct ubi_vmt_info *vmt;
    > > + struct ubi_ivol_info *ivol;
    > > + struct ubi_vtbl_info *vtbl;
    > > + struct ubi_acc_info *acc;
    > > + struct ubi_upd_info *upd;
    > > + struct ubi_eba_info *eba;
    > > + struct ubi_uif_info *uif;
    > > +};
    >
    > I don't know what went wrong here, but this does not at all
    > look ok. The members in here probably should all be part
    > of the ubi_info structure itself.

    Will be fixed, thanks.

    --
    Best regards,
    Artem Bityutskiy (Битюцкий Артём)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-19 12:33    [W:2.544 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site