Messages in this thread | | | From | Zach Brown <> | Subject | Re: [PATCH 2/2] aio: propogate post-EIOCBQUEUED errors to completion event | Date | Mon, 19 Feb 2007 14:57:09 -0800 |
| |
> Zach> So this patch introduces a helper, aio_propogate_error(), > > ...which is spelled incorrectly: aio_propagate_error.
Man, I am batting 1000! Randy also made fun of my 'intead'.
> Zach> which queues post-submission errors in the iocb so that they are > Zach> given to the user completion event when aio_complete() is > Zach> finally called. > > Ugly, but I can't think of a better way to do it, either.
Yeah, this seemed to be the lesser of the available evils. We (Chris and I, while in california) considered introducing a primitive to have the submission path wait for aio_complete() to be called so that it could just return the error. We also thought about turning EIOCB {RETRY,QUEUED} into bits on the iocb instead of return codes that we have to lovingly pass back up to fs/aio.c.
This seemed to be the least intrusive :/.
- z - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |