Messages in this thread | | | Subject | Re: [PATCH 1/7] Introduce the pagetable_operations and associated helper macros. | From | Adam Litke <> | Date | Mon, 19 Feb 2007 13:31:29 -0600 |
| |
On Mon, 2007-02-19 at 19:41 +0100, Arjan van de Ven wrote: > On Mon, 2007-02-19 at 10:31 -0800, Adam Litke wrote: > > Signed-off-by: Adam Litke <agl@us.ibm.com> > > --- > > > > include/linux/mm.h | 25 +++++++++++++++++++++++++ > > 1 files changed, 25 insertions(+), 0 deletions(-) > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index 2d2c08d..a2fa66d 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -98,6 +98,7 @@ struct vm_area_struct { > > > > /* Function pointers to deal with this struct. */ > > struct vm_operations_struct * vm_ops; > > + struct pagetable_operations_struct * pagetable_ops; > > > > please make it at least const, those things have no business ever being > written to right? And by making them const the compiler helps catch > that, and as bonus the data gets moved to rodata so that it won't share > cachelines with anything that gets dirty
Yep I agree. Changed.
-- Adam Litke - (agl at us.ibm.com) IBM Linux Technology Center
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |