Messages in this thread |  | | Subject | Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus | From | Joachim Fenkes <> | Date | Mon, 19 Feb 2007 11:36:23 -0500 |
| |
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote on 17.02.2007 19:37:25:
> > > Doh ! You are creating an of_device with no attached device-node ? That > > > is totally evil ! Why do you need that ? > > > > The driver creates a fake "ibmebus" device so all ibmebus based devices > > have > > a common parent device -- the vio bus does the same. > > > > What do you think about linking this device to the device tree "/" node? > > All > > ibmebus-based devices are linked to dt nodes residing directly beneath
> > "/", > > so the mapping would fit. > > No. If you do that, it shouldn't be an of_device based device. > > If you want then to be below a common parent, then create that parent of > a basic struct device type, that sort of thing. You should never > instanciate an of_device that has a NULL device node.
If I make the root device a basic struct device, it can't be part of ibmebus any longer. If we could create a busless device, we wouldn't have a problem, but I doubt that is possible.
Do you have any creative ideas?
> It's a generic problem with sysfs, I agree it somewhat sucks.
With ya.
Later, Joachim
--- Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer extraordinaire IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development 2) Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany eMail: fenkes@de.ibm.com -- Phone: +49 7031 16 1239
Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht Stuttgart, HRB 243294 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |