Messages in this thread |  | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] fix refrigerator() vs thaw_process() race | Date | Mon, 19 Feb 2007 00:28:03 +0100 |
| |
On Sunday, 18 February 2007 23:17, Oleg Nesterov wrote: > refrigerator() can miss a wakeup, "wait event" loop needs a proper memory > ordering. > > Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
ACK
> --- WQ/kernel/power/process.c~WAKE 2007-02-18 22:56:49.000000000 +0300 > +++ WQ/kernel/power/process.c 2007-02-19 01:04:26.000000000 +0300 > @@ -46,8 +46,10 @@ void refrigerator(void) > recalc_sigpending(); /* We sent fake signal, clean it up */ > spin_unlock_irq(¤t->sighand->siglock); > > - while (frozen(current)) { > - current->state = TASK_UNINTERRUPTIBLE; > + for (;;) { > + set_current_state(TASK_UNINTERRUPTIBLE); > + if (!frozen(current)) > + break; > schedule(); > } > pr_debug("%s left refrigerator\n", current->comm); > > >
-- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |