lkml.org 
[lkml]   [2007]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/1] - acpi_boot_init() making bad check on return code
Date
Applied.

thanks,
-Len
On Friday 16 February 2007 16:07, John Keller wrote:
> acpi_boot_init() is making a bad check on the return
> status from acpi_table_parse(). acpi_table_parse() now
> returns zero on success, one on failure.
>
> Signed-off-by: Aaron Young <ayoung@sgi.com>
> ---
>
> Index: release/arch/ia64/kernel/acpi.c
> ===================================================================
> --- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
> +++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
> @@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
> * information -- the successor to MPS tables.
> */
>
> - if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
> + if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
> printk(KERN_ERR PREFIX "Can't find MADT\n");
> goto skip_madt;
> }
> @@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
> * gets interrupts such as power and sleep buttons. If it's not
> * on a Legacy interrupt, it needs to be setup.
> */
> - if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
> + if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
> printk(KERN_ERR PREFIX "Can't find FADT\n");
>
> #ifdef CONFIG_SMP
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-17 04:09    [W:0.035 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site