lkml.org 
[lkml]   [2007]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH(Experimental) 1/4] freezer-cpu-hotplug core
    On 02/16, Srivatsa Vaddagiri wrote:
    >
    > On Fri, Feb 16, 2007 at 12:46:17PM +0530, Srivatsa Vaddagiri wrote:
    > > frozen. The only exception is cleaning up of per-cpu threads (which is
    > > not possible with processes frozen - if we can find a way to make that
    > > possible, then everything can be done in CPU_DEAD).
    >
    > How abt a patch like below?
    >
    > --- process.c.org 2007-02-16 13:38:39.000000000 +0530
    > +++ process.c 2007-02-16 13:38:59.000000000 +0530
    > @@ -47,7 +47,7 @@ void refrigerator(void)
    > recalc_sigpending(); /* We sent fake signal, clean it up */
    > spin_unlock_irq(&current->sighand->siglock);
    >
    > - while (frozen(current)) {
    > + while (frozen(current) && !kthread_should_stop()) {
    > current->state = TASK_UNINTERRUPTIBLE;
    > schedule();
    > }

    Instead, we can just clear PF_FROZEN before kthread_should_stop().
    I don't claim this is better, but this way we don't need to add a
    subtle change to process.c.

    > This should let us do kthread_stop() in CPU_DEAD itself (while processes
    > are frozen)? That would allow us to do everything from CPU_DEAD itself
    > (and not have CPU_DEAD_KILL_THREADS).

    ... and probably avoid many races, good.

    Oleg.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-16 20:49    [W:3.424 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site